Use {get,match}_def_path from rustc #3926
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flip1995
added
S-blocked
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 8, 2019
…ishearth Uplift `get_def_path` from Clippy cc rust-lang/rust-clippy#3926 cc rust-lang#59738 This uplifts `get_def_path` from Clippy. This is a follow up on the implementation of internal lints: rust-lang#59316 The internal lint implementation also copied the implementation of the `AbsolutePathPrinter`. To get rid of this code duplication this also uplifts the `get_def_path` function from Clippy. This also renames `match_path` to `match_def_path`, as it was originally named in Clippy. r? @Manishearth
sanxiyn
added a commit
to sanxiyn/rust
that referenced
this pull request
Apr 11, 2019
…ishearth Uplift `get_def_path` from Clippy cc rust-lang/rust-clippy#3926 cc rust-lang#59738 This uplifts `get_def_path` from Clippy. This is a follow up on the implementation of internal lints: rust-lang#59316 The internal lint implementation also copied the implementation of the `AbsolutePathPrinter`. To get rid of this code duplication this also uplifts the `get_def_path` function from Clippy. This also renames `match_path` to `match_def_path`, as it was originally named in Clippy. r? @Manishearth
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Apr 12, 2019
This fix is obsolet once rust-lang/rust#59779 and rust-lang#3926 is merged.
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Apr 12, 2019
This fix is obsolet once rust-lang/rust#59779 and rust-lang#3926 is merged.
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Apr 12, 2019
This fix is obsolet once rust-lang/rust#59779 and rust-lang#3926 is merged.
flip1995
force-pushed
the
def_path_uplift
branch
from
bebc8b8
to
bb16096
Compare
flip1995
added a commit
to flip1995/rust-clippy
that referenced
this pull request
Apr 12, 2019
This fix is obsolet once rust-lang/rust#59779 and rust-lang#3926 is merged.
Merged
bors
added a commit
that referenced
this pull request
Apr 12, 2019
Rustup cc rust-lang/rust#59227 (comment) This fix is obsolet once rust-lang/rust#59779 and #3926 is merged.
|
☔ The latest upstream changes (presumably #3945) made this pull request unmergeable. Please resolve the merge conflicts. |
flip1995
force-pushed
the
def_path_uplift
branch
from
bb16096
to
730c7c5
Compare
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 15, 2019
…ishearth Uplift `get_def_path` from Clippy cc rust-lang/rust-clippy#3926 cc rust-lang#59738 This uplifts `get_def_path` from Clippy. This is a follow up on the implementation of internal lints: rust-lang#59316 The internal lint implementation also copied the implementation of the `AbsolutePathPrinter`. To get rid of this code duplication this also uplifts the `get_def_path` function from Clippy. This also renames `match_path` to `match_def_path`, as it was originally named in Clippy. r? @Manishearth
flip1995
removed
the
S-blocked
|
☔ The latest upstream changes (presumably #3966) made this pull request unmergeable. Please resolve the merge conflicts. |
|
Nice! r=me when rebased and build is green |
flip1995
force-pushed
the
def_path_uplift
branch
from
730c7c5
to
840eac2
Compare
|
@bors r=phansch |
|
📌 Commit 840eac2 has been approved by |
bors
added a commit
that referenced
this pull request
Apr 17, 2019
Use {get,match}_def_path from rustc
This is a follow up of the uplift of `{get,match}_def_path` to rustc.
~~This is blocked on rust-lang/rust#59779~~
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up of the uplift of
{get,match}_def_pathto rustc.This is blocked on rust-lang/rust#59779