Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more test coverage for #11230 #13915

Merged
merged 1 commit into from
Jan 11, 2025
Merged

add more test coverage for #11230 #13915

merged 1 commit into from
Jan 11, 2025

Conversation

matthiaskrgr
Copy link
Member

@matthiaskrgr matthiaskrgr commented Dec 31, 2024

Closes #11230

changelog: none

@rustbot
Copy link
Collaborator

rustbot commented Dec 31, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Dec 31, 2024
@y21 y21 added this pull request to the merge queue Dec 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 31, 2024
@y21
Copy link
Member

y21 commented Dec 31, 2024

Weird, changelog CI failed even though the line is there 🤔

@y21 y21 added this pull request to the merge queue Dec 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 31, 2024
@matthiaskrgr
Copy link
Member Author

rebased, added the changelog none to the commit message and force pushed, maybe it helps?

@y21 y21 added this pull request to the merge queue Dec 31, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 31, 2024
@y21
Copy link
Member

y21 commented Jan 11, 2025

There's been some changes to the changelog CI; let's hope it works now.

@y21 y21 added this pull request to the merge queue Jan 11, 2025
Merged via the queue into rust-lang:master with commit a895beb Jan 11, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ice: args contain late-bound region at index 0 which can't be normalized
3 participants