Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend precedence for bitmasking and shift #13743

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Natsume-Neko
Copy link

Now we can lint for the expressions like _&_>>_, _<<_^_, etc. And will suggest to add parentheses like _&(_>>_) and (_<<_)^_.
I get implementation suggestions from #8735 (review).
changelog: extended [precedence] to lint for bit masking and bit shifting without parentheses
fixes #6632

Changelog: extended [`precedence`] to lint for bitmasking and bit shifting without parentheses
@rustbot
Copy link
Collaborator

rustbot commented Nov 28, 2024

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Jarcho (or someone else) some time within the next two weeks.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 28, 2024
Copy link
Contributor

@samueltardieu samueltardieu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice extensions.

tests/ui/precedence.stderr Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint masking bits and shift
4 participants