Don't lint CStr literals, do lint float literals in redundant_guards
#13698
+78
−41
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two changes to
redundant_guards
:Lint float literals. We used to do that before but that was changed in [
redundant_guards
]: don't lint on float literals #11305 because at the time there was a future compat warning and it was planned to make pattern matching floats a hard error.In make matching on NaN a hard error, and remove the rest of illegal_floating_point_literal_pattern rust#116284 it was decided to actually remove the lint and only make matching
NAN
specifically a hard error. TheNAN
part isn't relevant/important here because this PR only changes what literals are warned andf64::NAN
isn't a literal, but I've added a test anyway to make sure we continue to not lint there.Don't lint CStr literals because that can't be a pattern right now (fixes redundant_guards suggests change that doesn't compile for matching on CStr #13681)
changelog: none