Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not trigger if_let_mutex starting from Edition 2024 #13695

Merged
merged 1 commit into from
Nov 17, 2024

Conversation

alex-semenyuk
Copy link
Member

Close #13679

changelog: [if_let_mutex]: disable lint from Edition 2024 since stabilized if_let_rescope

@rustbot
Copy link
Collaborator

rustbot commented Nov 16, 2024

r? @y21

rustbot has assigned @y21.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Nov 16, 2024
@alex-semenyuk alex-semenyuk force-pushed the edition_dependent_lint branch 2 times, most recently from cf16044 to 2ce223a Compare November 17, 2024 08:03
@alex-semenyuk alex-semenyuk requested a review from y21 November 17, 2024 08:14
Copy link
Member

@y21 y21 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things then LGTM

@y21 y21 added this pull request to the merge queue Nov 17, 2024
Merged via the queue into rust-lang:master with commit 97b9e4a Nov 17, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should disable if_let_mutex in 2024 edition
3 participants