-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new lint: use_crate_prefix_for_self_imports #13662
Open
lengyijun
wants to merge
4
commits into
rust-lang:master
Choose a base branch
from
lengyijun:last_use_crate_prefix_for_self_imports
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
new lint: use_crate_prefix_for_self_imports #13662
lengyijun
wants to merge
4
commits into
rust-lang:master
from
lengyijun:last_use_crate_prefix_for_self_imports
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties
label
Nov 7, 2024
lengyijun
force-pushed
the
last_use_crate_prefix_for_self_imports
branch
from
November 7, 2024 11:40
2a70749
to
bfc0849
Compare
lengyijun
changed the title
use crate prefix for self imports
new lint use_crate_prefix_for_self_imports
Nov 7, 2024
lengyijun
changed the title
new lint use_crate_prefix_for_self_imports
new lint: use_crate_prefix_for_self_imports
Nov 7, 2024
lengyijun
force-pushed
the
last_use_crate_prefix_for_self_imports
branch
5 times, most recently
from
November 8, 2024 04:46
f74a6bc
to
6a0c669
Compare
llogiq
reviewed
Nov 8, 2024
/// ``` | ||
#[clippy::version = "1.84.0"] | ||
pub USE_CRATE_PREFIX_FOR_SELF_IMPORTS, | ||
style, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I understand that clearing up possible path confusion is a worthy cause, I'm afraid that introducing the lint as warn-by-default will lead to a lot of noise and broken CI jobs.
I'll discuss this on zulip.
cargo uibless
lengyijun
force-pushed
the
last_use_crate_prefix_for_self_imports
branch
from
November 13, 2024 03:26
6a0c669
to
7633f16
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog: [
use_crate_prefix_for_self_imports
]: new lintfix #13645
Only check main.rs and lib.rs
Known problem
Duplicate warning
TODO
Question
Although pass all tests, but if copy
lintcheck
to/tmp
, clippy will report two warnings (expected)