Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't lint unnamed consts and nested items within functions in missing_docs_in_private_items #13573

Merged
merged 2 commits into from
Nov 3, 2024

Conversation

y21
Copy link
Member

@y21 y21 commented Oct 20, 2024

With this change we no longer require doc comments for const _: () items as well as nested items in functions or other bodies. In both of those cases, rustdoc generates no documentation even with --document-private-items.

Fixes #13427 (first commit)
Fixes #13298 (second commit)
cc #5736 (comment)

changelog: [missing_docs_in_private_items]: avoid linting in more cases where rustdoc generates no documentation

@rustbot
Copy link
Collaborator

rustbot commented Oct 20, 2024

r? @Centri3

rustbot has assigned @Centri3.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 20, 2024
@Centri3
Copy link
Member

Centri3 commented Nov 3, 2024

Thanks, @bors r+

@bors
Copy link
Contributor

bors commented Nov 3, 2024

📌 Commit b3bf128 has been approved by Centri3

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Nov 3, 2024

⌛ Testing commit b3bf128 with merge ddd1a86...

@bors
Copy link
Contributor

bors commented Nov 3, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Centri3
Pushing ddd1a86 to master...

@bors bors merged commit ddd1a86 into rust-lang:master Nov 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
4 participants