Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the category of manual_is_power_of_two to pedantic #13553

Merged

Conversation

SpriteOvO
Copy link
Contributor

Fixes #13547.

The value being checked might be a bit flag, suggesting is_power_of_two for it would make the code unreadable.

changelog: [manual_is_power_of_two]: Change the category to pedantic

@rustbot
Copy link
Collaborator

rustbot commented Oct 15, 2024

r? @llogiq

rustbot has assigned @llogiq.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Oct 15, 2024
@llogiq
Copy link
Contributor

llogiq commented Oct 15, 2024

Makes sense.

@bors r+

@bors
Copy link
Contributor

bors commented Oct 15, 2024

📌 Commit ac81f17 has been approved by llogiq

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Oct 15, 2024

⌛ Testing commit ac81f17 with merge ddda954...

@bors
Copy link
Contributor

bors commented Oct 15, 2024

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: llogiq
Pushing ddda954 to master...

@bors bors merged commit ddda954 into rust-lang:master Oct 15, 2024
8 checks passed
@SpriteOvO SpriteOvO deleted the manual_is_power_of_two-change-category branch October 15, 2024 20:12
@xFrednet
Copy link
Member

xFrednet commented Oct 16, 2024

Thank you for the PR. The lint has been added about a month ago #13327. I think it would make sense to backport this change.

@rustbot label +beta-nominated

@rustbot rustbot added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 16, 2024
@flip1995 flip1995 added beta-accepted Accepted for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Nov 21, 2024
@flip1995
Copy link
Member

rust-lang/rust#133299

@xFrednet xFrednet removed the beta-accepted Accepted for backporting to the compiler in the beta channel. label Nov 22, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2024
…k-Simulacrum

[beta] Clippy backports

r? `@Mark-Simulacrum`

Backports:
- rust-lang/rust-clippy#13553
- rust-lang/rust-clippy#13600

The first is just a regrouping to a allow-by-default group, as we figured that the lint would be too noisy as a warn-by-default lint. That lint was added last release cycle, so we want to do the re-grouping before it hits stable.

The second is a bug fix for `&raw` references that are already stable in `1.82`, but we don't want to wait another release cycle for the fix to land on stable.

Both commits are already synced to the current `master branch`.
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 25, 2024
…k-Simulacrum

[beta] Clippy backports

r? `@Mark-Simulacrum`

Backports:
- rust-lang/rust-clippy#13553
- rust-lang/rust-clippy#13600

The first is just a regrouping to a allow-by-default group, as we figured that the lint would be too noisy as a warn-by-default lint. That lint was added last release cycle, so we want to do the re-grouping before it hits stable.

The second is a bug fix for `&raw` references that are already stable in `1.82`, but we don't want to wait another release cycle for the fix to land on stable.

Both commits are already synced to the current `master branch`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

manual_is_power_of_two is too broad for a default lint
6 participants