Fix/Issue11932: assert* in multi-condition after unrolling will cause lint nonminimal_bool
emit warning
#12083
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes Issue#11932
After
assert
,assert_eq
,assert_ne
, etc, assert family marcos unrolling in multi-condition expressions, lintnonminimal_bool
will recognize whole expression as a entirety, analyze each simple condition expr of them, and check whether can simplify them.But
assert
itself is a entirety to programmers, we don't need to lint onassert
. This commit add check whether lint snippet containsassert
when try to warning to an expression.changelog: [
nonminimal_bool
] add check for condition expression