Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[type_repetition_in_bounds]: Don't lint on derived code #10894

Merged
merged 6 commits into from
Jun 12, 2023

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented Jun 5, 2023

fixes #10504.

changelog: [type_repetition_in_bounds]: Don't lint on derived code

@rustbot
Copy link
Collaborator

rustbot commented Jun 5, 2023

r? @xFrednet

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label Jun 5, 2023
@blyxyas
Copy link
Member

blyxyas commented Jun 7, 2023

I'm curious what the difference would be if is_from_proc_macro was used instead.

In this new commit, it's about ~15% faster. Not really worth it only for performance, but the clean code really makes this worth it imo (and making it easier for future contributions).

Copy link
Member

@blyxyas blyxyas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is ready to merge. Thanks!

cc @xFrednet

@xFrednet
Copy link
Member

Sounds like you're back in action. Ain't no rest for the wicket, right? ^^

I'll give this a final review in the next couple of days. Thank you for the reviewing effort @blyxyas

Copy link
Member

@xFrednet xFrednet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just one tiny question before the merge :)

clippy_utils/src/check_proc_macro.rs Outdated Show resolved Hide resolved
@xFrednet
Copy link
Member

This version looks good to me, thank you! @Centri3

Also thank you, @blyxyas, for the review support!

@bors r=blyxyas,xFrednet

@bors
Copy link
Contributor

bors commented Jun 12, 2023

📌 Commit 4191de3 has been approved by blyxyas,xFrednet

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 12, 2023

⌛ Testing commit 4191de3 with merge 903fe3b...

@bors
Copy link
Contributor

bors commented Jun 12, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: blyxyas,xFrednet
Pushing 903fe3b to master...

@bors bors merged commit 903fe3b into rust-lang:master Jun 12, 2023
@Centri3 Centri3 deleted the type_repetition_in_bounds branch June 12, 2023 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

clippy::type_repetition_in_bounds triggers on derived code
5 participants