-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[type_repetition_in_bounds
]: Don't lint on derived code
#10894
Conversation
r? @xFrednet (rustbot has picked a reviewer for you, use r? to override) |
In this new commit, it's about ~15% faster. Not really worth it only for performance, but the clean code really makes this worth it imo (and making it easier for future contributions). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is ready to merge. Thanks!
cc @xFrednet
Sounds like you're back in action. Ain't no rest for the wicket, right? ^^ I'll give this a final review in the next couple of days. Thank you for the reviewing effort @blyxyas |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just one tiny question before the merge :)
☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test |
fixes #10504.
changelog: [
type_repetition_in_bounds
]: Don't lint on derived code