Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lints for disallowing usage of to_xx_bytes and from_xx_bytes #10826

Merged
merged 9 commits into from
Jun 5, 2023

Conversation

Centri3
Copy link
Member

@Centri3 Centri3 commented May 25, 2023

Adds host_endian_bytes, little_endian_bytes and big_endian_bytes

Closes #10765

v - not sure what to put here since this adds 3 lints
changelog: Add host_endian_bytes, little_endian_bytes and big_endian_bytes lints

@rustbot
Copy link
Collaborator

rustbot commented May 25, 2023

r? @Manishearth

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 25, 2023
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a neat idea! I'm in favor, minor nit

clippy_lints/src/endian_bytes.rs Outdated Show resolved Hide resolved
@Manishearth
Copy link
Member

@bors r+

thanks!

@bors
Copy link
Contributor

bors commented Jun 5, 2023

📌 Commit 7fe200e has been approved by Manishearth

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Jun 5, 2023

⌛ Testing commit 7fe200e with merge eacd095...

@bors
Copy link
Contributor

bors commented Jun 5, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing eacd095 to master...

1 similar comment
@bors
Copy link
Contributor

bors commented Jun 5, 2023

☀️ Test successful - checks-action_dev_test, checks-action_remark_test, checks-action_test
Approved by: Manishearth
Pushing eacd095 to master...

@bors bors merged commit eacd095 into rust-lang:master Jun 5, 2023
@Centri3 Centri3 deleted the endian_bytes branch June 5, 2023 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lint uses of to/from_ne_bytes
4 participants