Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support the rust-version field in Cargo.toml to specify the MSRV #7765

Closed
jonasbb opened this issue Oct 4, 2021 · 1 comment · Fixed by #8774
Closed

Support the rust-version field in Cargo.toml to specify the MSRV #7765

jonasbb opened this issue Oct 4, 2021 · 1 comment · Fixed by #8774
Labels
C-an-interesting-project Category: Interesting projects, that usually are more involved design/code wise. C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages

Comments

@jonasbb
Copy link

jonasbb commented Oct 4, 2021 •
edited by rustbot
Loading

The first crates are starting to make use of the rust-version field in Cargo.toml, which gets stabilized with the 1.56 version of rust, see rust-lang/rust#65262 and rust-lang/cargo#9732.

So far it does not seem like Clippy is able to understand this field. It only supports specifying it in it's own config file and unstably as an inner attribute (Readme).

@rustbot label +C-enhancement
@rustbot rustbot added the C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages label Oct 4, 2021
@xFrednet xFrednet added the C-an-interesting-project Category: Interesting projects, that usually are more involved design/code wise. label Oct 5, 2021
@flip1995
Copy link
Member

flip1995 commented Oct 8, 2021

@rustbot claim

@flip1995 flip1995 mentioned this issue Oct 8, 2021
Merged
bors added a commit to rust-lang/cargo that referenced this issue Oct 12, 2021
@bors
Auto merge of #9967 - flip1995:rust_version_meta, r=alexcrichton
2e6a4e1 
Add rust_metadata to SerializedPackage

After the rust_version field was stabilized in #9732 this adds the
rust_version as output to the `cargo metadata` command, so tools like
Clippy can read and use it as well.

We will probably need this for rust-lang/rust-clippy#7765
@jonasbb jonasbb changed the title Support the rust-version field in Cargo.toml Support the rust-version field in Cargo.toml to specify the MSRV Oct 19, 2021
@flip1995 flip1995 mentioned this issue Oct 27, 2021
Merged
@jonasbb jonasbb mentioned this issue Nov 6, 2021
Closed
@est31 est31 mentioned this issue Apr 11, 2022
Closed
@flip1995 flip1995 mentioned this issue May 2, 2022
Merged
@flip1995 flip1995 removed their assignment May 2, 2022
@bors bors closed this as completed in b776fb8 Jun 28, 2022
@jswrenn jswrenn mentioned this issue Oct 25, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-an-interesting-project Category: Interesting projects, that usually are more involved design/code wise. C-enhancement Category: Enhancement of lints, like adding more cases or adding help messages
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

try reading rust-version from Cargo.toml hellow554/rust-clippy
4 participants
@jonasbb @flip1995 @xFrednet @rustbot