Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

custom ice message test fails inside rustc repo due to wrong file path #4872

Closed
matthiaskrgr opened this issue Dec 2, 2019 · 0 comments · Fixed by #4875
Closed

custom ice message test fails inside rustc repo due to wrong file path #4872

matthiaskrgr opened this issue Dec 2, 2019 · 0 comments · Fixed by #4875
Labels
C-bug Category: Clippy is not doing the correct thing L-tests Lint: Lints test code

Comments

@matthiaskrgr
Copy link
Member

#4588
The problem is that the test expects the output
thread 'rustc' panicked at 'Testing the ICE message', clippy_lints/src/utils/internal_lints.rs

but when running clippy tests from inside the rustc repo, the source path will read
src/tools/clippy/clippy_lints/src/utils/internal_lints.rs which will fail the test:

diff of stderr:

-thread 'rustc' panicked at 'Testing the ICE message', clippy_lints/src/utils/internal_lints.rs
+thread 'rustc' panicked at 'Testing the ICE message', src/tools/clippy/clippy_lints/src/utils/internal_lints.rs
 note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace.

 error: internal compiler error: unexpected panic

 note: the compiler unexpectedly panicked. this is a bug.

 note: we would appreciate a bug report: https://github.com/rust-lang/rust-clippy/issues/new

 note: Clippy version: foo

cc @phansch
@matthiaskrgr matthiaskrgr added L-tests Lint: Lints test code C-bug Category: Clippy is not doing the correct thing labels Dec 2, 2019
@phansch phansch self-assigned this Dec 2, 2019
@flip1995 flip1995 mentioned this issue Dec 2, 2019
Merged
bors added a commit that referenced this issue Dec 2, 2019
@bors
Auto merge of #4875 - flip1995:rustup, r=matthiaskrgr
7a943a9 
Rustup to rust-lang/rust#64736

cc rust-lang/rust#64736

Fixes #4872

changelog: none
@phansch phansch removed their assignment Dec 2, 2019
@bors bors closed this as completed in 511dece Dec 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
C-bug Category: Clippy is not doing the correct thing L-tests Lint: Lints test code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Rustup to rust-lang/rust#64736 flip1995/rust-clippy
2 participants
@matthiaskrgr @phansch