Spot wrong usage of bitwise and operator

[leonardo-m]

I'd like Clippy to warn in this expression suggesting that this is probably an error, and that the programmer perhaps meant to use "&&" instead:

fn foo2(x1: i32, x2: i32) {
    if (x1 < x2) & (x1 != 0) {}
}

[mcarton]

/me disappointed
/me expected that to be a type-error in rustc

[leonardo-m]

In my opinion there's a small number of Clippy lints that should be Rustc errors (or warnings).

[mcarton]

What I meant is I did not expect & to even exist on booleans.

[oli-obk]

Actually there are valid use cases for this, because the regular bool ops short circuit but in that case the lint can be disabled, since these cases are rare.

[clarfonthey]

Perhaps this could only apply to constant operations and functions that are known to have no side effects? That way those cases don't require disabling the lint.

Or better, we split into two lints, one that does just the ones that are known to have no side effects, and one that covers the ones that might have side effects. That way people can disable the ones for side effects while still having the benefit of checking cases like these.

[mcarton]

@oli-obk I know but this is rare enough that I would have expected to have to bind the expressions (and of course add a comment) rather that be allowed to use & on booleans. Oh well, it's too late anyway.

[mcarton]

Wrong button (morning 😅).

[leonardo-m]

Wrong button (morning

It's a common mistake, so I've sent a "bug report" to GitHub about the design of those two buttons.