Add check for empty cfg all and any conditions

rust-lang · May 19, 2023 · e3ad36c · e3ad36c
1 parent 5328852
commit e3ad36c
Show file tree

Hide file tree

Showing 4 changed files with 33 additions and 1 deletion.
diff --git a/clippy_lints/src/attrs.rs b/clippy_lints/src/attrs.rs
@@ -796,6 +796,14 @@ fn check_nested_cfg(cx: &EarlyContext<'_>, items: &[NestedMetaItem]) {
                             }
                         },
                     );
+                } else if list.is_empty() {
+                    span_lint_and_then(
+                        cx,
+                        NON_MINIMAL_CFG,
+                        meta.span,
+                        "unneeded sub `cfg` when there is no condition",
+                        |_| {},
+                    );
                 }
             }
         }

diff --git a/tests/ui/non_minimal_cfg.fixed b/tests/ui/non_minimal_cfg.fixed
@@ -11,4 +11,10 @@ fn wasi() {}
 #[cfg(all(unix, not(windows)))]
 fn the_end() {}
 
+#[cfg(all())]
+fn all() {}
+
+#[cfg(any())]
+fn any() {}
+
 fn main() {}
diff --git a/tests/ui/non_minimal_cfg.rs b/tests/ui/non_minimal_cfg.rs
@@ -11,4 +11,10 @@ fn wasi() {}
 #[cfg(all(any(unix), all(not(windows))))]
 fn the_end() {}
 
+#[cfg(all())]
+fn all() {}
+
+#[cfg(any())]
+fn any() {}
+
 fn main() {}
diff --git a/tests/ui/non_minimal_cfg.stderr b/tests/ui/non_minimal_cfg.stderr
@@ -24,5 +24,17 @@ error: unneeded sub `cfg` when there is only one condition
 LL | #[cfg(all(any(unix), all(not(windows))))]
    |                      ^^^^^^^^^^^^^^^^^ help: try: `not(windows)`
 
-error: aborting due to 4 previous errors
+error: unneeded sub `cfg` when there is no condition
+  --> $DIR/non_minimal_cfg.rs:14:7
+   |
+LL | #[cfg(all())]
+   |       ^^^^^
+
+error: unneeded sub `cfg` when there is no condition
+  --> $DIR/non_minimal_cfg.rs:17:7
+   |
+LL | #[cfg(any())]
+   |       ^^^^^
+
+error: aborting due to 6 previous errors