ir: Cleanup name duplication in aliases and named types. #461
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's just dumb.
fitzgen
approved these changes
Jan 30, 2017
| _ => false, | ||
| } | ||
| } | ||
|
|
||
| /// Creates a new named type, with name `name`. | ||
| pub fn named(name: String) -> Self { | ||
| assert!(!name.is_empty()); | ||
| // TODO: stop duplicating the name, it's stupid. |
| @@ -143,17 +127,15 @@ impl Type { | |||
| TypeKind::BlockPointer | | |||
| TypeKind::Int(..) | | |||
| TypeKind::Float(..) | | |||
| TypeKind::Named(..) => true, | |||
| TypeKind::Named => true, | |||
| _ => false, | |||
| } | |||
| } | |||
|
|
|||
| /// Creates a new named type, with name `name`. | |||
| pub fn named(name: String) -> Self { | |||
| assert!(!name.is_empty()); | |||
There was a problem hiding this comment.
Maybe it would be good to assert about identifiers like we now do in codegen here as well?
There was a problem hiding this comment.
Well, the point is that invalid identifiers may come here, we just don't want to generate code for them. It'd be good if they didn't, but more work needs to happen so that's true.
|
@bors-servo r=fitzgen |
|
📌 Commit a46971c has been approved by |
|
⚡ Test exempted - status |
bors-servo
pushed a commit
that referenced
this pull request
Jan 30, 2017
ir: Cleanup name duplication in aliases and named types. It's just dumb. r? @fitzgen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's just dumb.
r? @fitzgen