Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Move forward Rust for Linux version #2970

Merged
merged 1 commit into from
Nov 2, 2024
Merged

ci: Move forward Rust for Linux version #2970

merged 1 commit into from
Nov 2, 2024

Conversation

ojeda
Copy link
Contributor

@ojeda ojeda commented Nov 2, 2024

The CI is hitting errors and warnings now [1], due to Rust 1.82.0 being used to build an older Linux kernel:

warning: the feature `new_uninit` has been stable since 1.82.0 and no longer requires an attribute to enable
  --> rust/kernel/lib.rs:17:12
   |
17 | #![feature(new_uninit)]
   |            ^^^^^^^^^^
   |
   = note: `#[warn(stable_features)]` on by default

error[E0658]: use of unstable library feature 'box_uninit_write'
  --> rust/kernel/alloc/box_ext.rs:25:12
   |
25 |         Ok(Box::write(b, x))
   |            ^^^^^^^^^^
   |
   = note: see issue #129397 <https://github.com/rust-lang/rust/issues/129397> for more information
   = help: add `#![feature(box_uninit_write)]` to the crate attributes to enable
   = note: this compiler was built on 2024-10-15; consider upgrading it if it is out of date

Which is due to the current commit hash being from the Linux v6.10 cycle, when we did not yet support several Rust versions.

Thus update the hash with a newer tag (the latest available) that does support several Rust versions, including the latest.

In any case, updating is a good idea since it has been a while since we introduced Rust for Linux in the CI, and the intention is to update it from time to time nevertheless.

Link: https://github.com/rust-lang/rust-bindgen/actions/runs/11637602211/job/32411071463?pr=2969#step:6:1362 [1]

The CI is hitting errors and warnings now [1], due to Rust 1.82.0 being
used to build an older Linux kernel:

    warning: the feature `new_uninit` has been stable since 1.82.0 and no longer requires an attribute to enable
      --> rust/kernel/lib.rs:17:12
       |
    17 | #![feature(new_uninit)]
       |            ^^^^^^^^^^
       |
       = note: `#[warn(stable_features)]` on by default

    error[E0658]: use of unstable library feature 'box_uninit_write'
      --> rust/kernel/alloc/box_ext.rs:25:12
       |
    25 |         Ok(Box::write(b, x))
       |            ^^^^^^^^^^
       |
       = note: see issue #129397 <rust-lang/rust#129397> for more information
       = help: add `#![feature(box_uninit_write)]` to the crate attributes to enable
       = note: this compiler was built on 2024-10-15; consider upgrading it if it is out of date

Which is due to the current commit hash being from the Linux v6.10 cycle,
when we did not yet support several Rust versions.

Thus update the hash with a newer tag (the latest available) that does
support several Rust versions, including the latest.

In any case, updating is a good idea since it has been a while since we
introduced Rust for Linux in the CI, and the intention is to update it
from time to time nevertheless.

Link: https://github.com/rust-lang/rust-bindgen/actions/runs/11637602211/job/32411071463?pr=2969#step:6:1362 [1]
Signed-off-by: Miguel Ojeda <[email protected]>
@ojeda ojeda added the rust-for-linux Issues relevant to the Rust for Linux project label Nov 2, 2024
@pvdrz pvdrz added this pull request to the merge queue Nov 2, 2024
Merged via the queue into rust-lang:main with commit 9f59212 Nov 2, 2024
33 checks passed
@ojeda ojeda deleted the rfl branch November 2, 2024 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rust-for-linux Issues relevant to the Rust for Linux project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants