Generated name override #2228
Merged
Generated name override #2228
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pvdrz
approved these changes
Sep 9, 2022
|
@justsmth I have one question. What happens if you use this new callback to set all the function names to the same value? |
I've not tried that, but at best the bindings generated would not compile due to name conflicts. We could potentially detect/prevent such a mistake within rust-bindgen. However, I'm not sure doing so would be worth the added complexity. |
pvdrz
approved these changes
Sep 9, 2022
|
☔ The latest upstream changes (presumably #2284) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses issue: #1375
generated_name_overridecallback to theParseCallbackstrait.This PR is a cleaned up version of previous: #2214