Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Debug macOS CI problems #6202

Closed
wants to merge 21 commits into from
Closed

Debug macOS CI problems #6202

wants to merge 21 commits into from

Conversation

jonas-schievink
Copy link
Contributor

No description provided.

@jonas-schievink jonas-schievink mentioned this pull request Oct 12, 2020
Merged
@matklad
Copy link
Member

matklad commented Oct 12, 2020

I wonder if this has to do with rustc version. Proc macro ABI changed in 1.47, but CI still uses 1.46.

@jonas-schievink
Copy link
Contributor Author

Locally that just resulted in test failures, I would not expect that to affect building r-a itself

@lnicola
Copy link
Member

lnicola commented Oct 12, 2020

CI updates to 1.47, but those errors are really weird:

error[E0463]: can't find crate for `serde_derive` which `serde_json` depends on

@matklad
Copy link
Member

matklad commented Oct 12, 2020

But mac CI is using 1.46: https://github.com/rust-analyzer/rust-analyzer/runs/1242732678#step:4:21. Filed #6206 to not be surprised by this.

@matklad
Copy link
Member

matklad commented Oct 12, 2020

Ah, no, CI updates 1.46 to 1.47...

@lnicola
Copy link
Member

lnicola commented Oct 12, 2020

Yep. The GitHub Actions image has 1.46, but the toolchain action updates it.

Jonas Schievink added 3 commits October 12, 2020 17:40
@matklad matklad mentioned this pull request Oct 12, 2020
Merged
@jonas-schievink
Copy link
Contributor Author

Turns out this is a bug in BSD tar, which is what macOS uses: rust-lang/cargo#8603

Apart from disabling caching, there doesn't seem to be any way to fix this on our end.

@jonas-schievink
Copy link
Contributor Author

Actually we can just use GNU tar instead...

@jonas-schievink
Copy link
Contributor Author

#6208 should fix this

@jonas-schievink jonas-schievink deleted the macos-ci branch October 12, 2020 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonas-schievink @matklad @lnicola