Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to fully dynamically dispatched salsa #5242

Merged
merged 1 commit into from
Jul 7, 2020
Merged

Switch to fully dynamically dispatched salsa #5242

merged 1 commit into from
Jul 7, 2020

Conversation

matklad
Copy link
Member

@matklad matklad commented Jul 7, 2020

This improves compile times quite a bit

bors r+
🤖

@matklad
Switch to fully dynamically dispatched salsa
4bbc385 
This improves compile times quite a bit
@bors
Copy link
Contributor

bors bot commented Jul 7, 2020

Build succeeded:

@bors bors bot merged commit 7a8597b into rust-lang:master Jul 7, 2020
@lnicola lnicola mentioned this pull request Jul 7, 2020
Closed
@kjeremy
Copy link
Contributor

kjeremy commented Jul 7, 2020

Perf/memory impact?

@lnicola
Copy link
Member

lnicola commented Jul 7, 2020 •
edited
Loading

Not much, some slight memory usage decrease:

Database loaded 282.166469ms
Crates in this dir: 37
Total modules found: 489
Total declarations: 9571
Total functions: 7451
Item Collection: 17.752670785s, 0b allocated 0b resident
Total expressions: 191940                                                                                                                          
Expressions of unknown type: 1564 (0%)
Expressions of partially unknown type: 943 (0%)
Type mismatches: 455
Inference: 29.180093714s, 0b allocated 0b resident
Total: 46.932773185s, 0b allocated 0b resident
47.76user 0.71system 0:48.57elapsed 99%CPU (0avgtext+0avgdata 1452196maxresident)k
0inputs+0outputs (0major+381613minor)pagefaults 0swaps

Database loaded 274.277544ms
Crates in this dir: 37
Total modules found: 489
Total declarations: 9571
Total functions: 7451
Item Collection: 17.483419404s, 0b allocated 0b resident
Total expressions: 191940                                                                                                                        
Expressions of unknown type: 1576 (0%)
Expressions of partially unknown type: 955 (0%)
Type mismatches: 455
Inference: 28.555933121s, 0b allocated 0b resident
Total: 46.039360356s, 0b allocated 0b resident
46.81user 0.72system 0:47.65elapsed 99%CPU (0avgtext+0avgdata 1398384maxresident)k
0inputs+0outputs (0major+368339minor)pagefaults 0swaps

@matklad matklad deleted the moardyn branch September 5, 2020 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@matklad @kjeremy @lnicola