Support returning non-hierarchical symbols #4113
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kjeremy
force-pushed
the
support-non-hierarchy
branch
from
af4a605 to
5c0cc96
Compare
|
I'm not thrilled that the shape of the code in the two |
matklad
reviewed
Apr 23, 2020
If `hierarchicalDocumentSymbolSupport` is not true in the client capabilites then it does not support the `DocumentSymbol[]` return type from the `textDocument/documentSymbol` request and we must fall back to `SymbolInformation[]`. This is one of the few requests that use the client capabilities to differentiate between return types and could cause problems for clients. See microsoft/language-server-protocol#538 (comment) for more context. Found while looking at rust-lang#144
kjeremy
force-pushed
the
support-non-hierarchy
branch
from
5c0cc96 to
0619c67
Compare
|
bors r+ |
bors bot
added a commit
that referenced
this pull request
Apr 25, 2020
4113: Support returning non-hierarchical symbols r=matklad a=kjeremy If `hierarchicalDocumentSymbolSupport` is not true in the client capabilites then it does not support the `DocumentSymbol[]` return type from the `textDocument/documentSymbol` request and we must fall back to `SymbolInformation[]`. This is one of the few requests that use the client capabilities to differentiate between return types and could cause problems for clients. See microsoft/language-server-protocol#538 (comment) for more context. Found while looking at #144 4136: add support for cfg feature attributes on expression #4063 r=matklad a=bnjjj close issue #4063 4141: Fix typo r=matklad a=Veetaha 4142: Remove unnecessary async from vscode language client creation r=matklad a=Veetaha 4145: Remove dead code r=matklad a=matklad bors r+ 🤖 Co-authored-by: kjeremy <[email protected]> Co-authored-by: Benjamin Coenen <[email protected]> Co-authored-by: veetaha <[email protected]> Co-authored-by: Aleksey Kladov <[email protected]>
|
This PR was included in a batch that was canceled, it will be automatically retried |
|
Build succeeded: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
hierarchicalDocumentSymbolSupportis not true in the client capabilitesthen it does not support the
DocumentSymbol[]return type from thetextDocument/documentSymbolrequest and we must fall back toSymbolInformation[].This is one of the few requests that use the client capabilities to
differentiate between return types and could cause problems for clients.
See microsoft/language-server-protocol#538 (comment) for more context.
Found while looking at #144