Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Optimize find_path for sysroot library search some more" #17841

Conversation

traviscross
Copy link

@traviscross traviscross commented Aug 9, 2024

This reverts commit 733cb1e.

Reverting this commit fixes the behavior of rust-analyzer.imports.preferNoStd.

This fixes #17840.

cc @Veykril

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 9, 2024
This reverts commit 733cb1e.

Reverting this commit fixes the behavior of
[`rust-analyzer.imports.preferNoStd`][].

This fixes rust-lang#17840.

[`rust-analyzer.imports.preferNoStd`]: https://rust-analyzer.github.io/manual.html#rust-analyzer.imports.preferNoStd
@traviscross traviscross force-pushed the TC/revert-733cb1e64-to-fix-prefer-nostd branch from 5910e88 to 21eae58 Compare August 9, 2024 21:22
@Veykril
Copy link
Member

Veykril commented Aug 10, 2024

#17844 fixes the issue

@Veykril Veykril closed this Aug 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Commit 733cb1e64 breaks imports.preferNoStd
3 participants