Fix false positive type mismatch in const reference patterns #16131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
HKalbasi
force-pushed
the
rustc-tests-fixup
branch
from
dd37f22 to
fa5a327
Compare
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Veykril
reviewed
Dec 15, 2023
| Pat::Or(pats) => pats.iter().all(|p| self.is_non_ref_pat(body, *p)), | ||
| Pat::Path(p) => { | ||
| let v = self.resolve_value_path_inner(p, pat.into()); | ||
| v.is_some_and(|x| !matches!(x.0, hir_def::resolver::ValueNs::ConstId(_))) |
There was a problem hiding this comment.
I think we need to accomodate for enum unit variants and unit structs here as well no? (since we don't inherently treat their resolution as a const)
There was a problem hiding this comment.
This function should return true for structs and enum variants, since we need to automatically dereference in those cases. That is, this code is valid:
match &&&&&&&e {
Enum::Variant => ()
}But this is type error:
const ENUM_VARIANT_AS_CONST: Enum = Enum::Variant;
match &&&&&&&e {
ENUM_VARIANT_AS_CONST => ()
}
This was referenced May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.