De-duplicate cargo watch diagnostics
#1438
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When building multiple targets (e.g. debug and test) it's common for the shared code to emit a diagnostic for each target. This is due to rust-lang/cargo#1534 and its many duplicates. While this renders fine in the text view it can be confusing when looking at the error list or count. This adds an `areDiagnosticsEqual` helper and then only pushes the new diagnostic if we haven't seen it before. This doesn't do a full proper equality; it only looks at the parts of the diagnostic we set. I couldn't find an appropriate helper function in the VSCode API.
This is consistent with `getLevel`
|
Superseded by the much more ambitious #1439 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When building multiple targets (e.g. debug and test) it's common for the shared code to emit a diagnostic for each target. This is due to rust-lang/cargo#1534 and its many duplicates.
While this renders fine in the text view it can be confusing when looking at the error list or count.
This adds an
areDiagnosticsEqualhelper and then only pushes the new diagnostic if we haven't seen it before. This doesn't do a full proper equality; it only looks at the parts of the diagnostic we set. I couldn't find an appropriate helper function in the VSCode API.