Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

internal: Re-use the resolver in InferenceContext instead of rebuilding it whenever needed #14261

Merged
merged 4 commits into from
Mar 6, 2023

Conversation

Veykril
Copy link
Member

@Veykril Veykril commented Mar 6, 2023

This reduced inference time on my local build by roughly ~1 sec (out of like 60)

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 6, 2023
@Veykril
Copy link
Member Author

Veykril commented Mar 6, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Mar 6, 2023

📌 Commit d8b1ec6 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 6, 2023

⌛ Testing commit d8b1ec6 with merge a360fab...

@bors
Copy link
Contributor

bors commented Mar 6, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing a360fab to master...

@bors bors merged commit a360fab into rust-lang:master Mar 6, 2023
@Veykril Veykril deleted the ty-perf branch March 6, 2023 11:37
@bors bors mentioned this pull request Mar 6, 2023
@mohon8156 mohon8156 linked an issue Mar 13, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data analytics and ads work service
3 participants