Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow generate_function to generate in different local crate #14238

Merged

Conversation

lowr
Copy link
Contributor

@lowr lowr commented Mar 3, 2023

Closes #14224

This PR allows generate_function assist to generate in crates other than the current one. I took a step further from the original request and made it allow to generate in any local crates since it looked reasonable and IDE layer doesn't really know about packages.

(actually we have been checking which crate we're generating in only for methods and not for freestanding functions, so we were providing the assist for e.g. std::foo$0(); it's both feature and fix in a sense)

The first commit is a drive-by fix unrelated to the feature.

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 3, 2023
@Veykril
Copy link
Member

Veykril commented Mar 3, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Mar 3, 2023

📌 Commit bda2af7 has been approved by Veykril

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 3, 2023

⌛ Testing commit bda2af7 with merge 3b857e1...

@bors
Copy link
Contributor

bors commented Mar 3, 2023

☀️ Test successful - checks-actions
Approved by: Veykril
Pushing 3b857e1 to master...

@bors bors merged commit 3b857e1 into rust-lang:master Mar 3, 2023
@mohon8156 mohon8156 linked an issue Mar 13, 2023 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data analytics and ads work service Show quick-fix to add a missing method when editing the same package
4 participants