Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Support if- and while- let chains #11375

Merged
merged 8 commits into from
Feb 21, 2022
Merged

feat: Support if- and while- let chains #11375

merged 8 commits into from
Feb 21, 2022

Conversation

ChayimFriedman2
Copy link
Contributor

@ChayimFriedman2 ChayimFriedman2 commented Jan 30, 2022 •
edited
Loading

Closes #11320.

@ChayimFriedman2 ChayimFriedman2 marked this pull request as draft January 30, 2022 01:53
@ChayimFriedman2 ChayimFriedman2 marked this pull request as ready for review February 1, 2022 09:35
@ChayimFriedman2
Copy link
Contributor Author

@Veykril What with this?

@Veykril
Copy link
Member

Veykril commented Feb 13, 2022

Will take a look at this once I get time as this is a larger PR to review

@ChayimFriedman2
Copy link
Contributor Author

Fine 😃 I just wanted to make sure this wasn't forgotten.

Veykril
Veykril reviewed Feb 20, 2022
View reviewed changes
Copy link
Member

@Veykril Veykril left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm with one small nit

crates/syntax/src/ast/node_ext.rs Outdated Show resolved Hide resolved
@ChayimFriedman2
Parse let expressions in order to support let chains
de8633f 
We still need to reject freestanding `let` expressions: see #11320 (comment).
@ChayimFriedman2
Lower let expressions
6bf6f4f
@ChayimFriedman2
Type-inference for let expressions
fe1e324
@ChayimFriedman2
Fix various IDE features
13ac5c3 
As a side benefit, we got `let` guard support for `move_guard` for free.
@ChayimFriedman2
Update tests
a1b7169 
Unfortunately, we lost some recovery for expressions.
@ChayimFriedman2
Validate let expressions
821b791 
Emit an error if they're found in an invalid position.
@ChayimFriedman2
Upgrade ungrammar to 1.15.0
9881614
@ChayimFriedman2
Change single_let() and is_pattern_cond() to free functions
f70512c
@Veykril
Copy link
Member

Veykril commented Feb 21, 2022

Thanks!
bors r+

@bors
Copy link
Contributor

bors bot commented Feb 21, 2022

Build succeeded:

@bors bors bot merged commit c67660f into rust-lang:master Feb 21, 2022
@ChayimFriedman2 ChayimFriedman2 deleted the if-while-let-chains branch February 21, 2022 18:50
@lnicola lnicola mentioned this pull request Feb 26, 2022
Closed
@ChayimFriedman2 ChayimFriedman2 mentioned this pull request Feb 27, 2022
Merged
bors bot added a commit that referenced this pull request Feb 27, 2022
@bors @ChayimFriedman2
Merge #11570
bc2ce4c 
11570: minor: Remove misleading comments r=lnicola a=ChayimFriedman2

They're not true anymore after #11375.

Co-authored-by: Chayim Refael Friedman <[email protected]>
tysg pushed a commit to tysg/rust-analyzer that referenced this pull request Mar 3, 2022
@ChayimFriedman2 @tysg
Remove misleading comments
8535474 
They're not true anymore after rust-lang#11375.
@Veykril Veykril mentioned this pull request Mar 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Veykril Veykril Veykril left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for let chains
2 participants
@ChayimFriedman2 @Veykril