Skip to content
This repository has been archived by the owner on Dec 29, 2022. It is now read-only.

Fix stack overflow on windows. #942

Merged
merged 1 commit into from
Jul 14, 2018
Merged

Fix stack overflow on windows. #942

merged 1 commit into from
Jul 14, 2018

Conversation

ehuss
Copy link
Contributor

@ehuss ehuss commented Jul 14, 2018

Fixes #838

@alexheretic
Copy link
Member

Thanks! I can confirm this does fix #838

@Xanewok
Copy link
Member

Xanewok commented Jul 14, 2018

Nice catch! Since we're using the rls as rustc shim, it's only fair to use the same parameters as rustc binary itself.

link to rustc.rs rationale

@Xanewok Xanewok merged commit f07b789 into rust-lang:master Jul 14, 2018
@nrc
Copy link
Member

nrc commented Jul 17, 2018

@ehuss Thanks so much for this PR! I had been dreading trying to fix this.

@ehuss ehuss mentioned this pull request Dec 20, 2018
Closed
@passcod passcod mentioned this pull request Feb 9, 2019
Closed
@Xanewok Xanewok mentioned this pull request Mar 13, 2019
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ehuss @alexheretic @Xanewok @nrc