This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
Split RLS into bin/lib and move some tests to Cargo integration test format #1210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xanewok
force-pushed
the
split-bin-lib
branch
2 times, most recently
from
b23cd72 to
93fee34
Compare
nrc
approved these changes
Jan 8, 2019
They basically spin up the entire server so it's almost end-to-end, after all.
And don't doc-test RLS library while we're at it. For now, it doesn't make sense to do so, since because of how RLS is architectured, every test would have to potentially always include a lengthy initialization code. This would be too much noise and of dubious benefit.
|
Done, thanks! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This cleans up our testing infrastructure and allows integration tests to test the library directly (just like old tests did) and end-to-end (like the new ones, where we spawn a process and communicate with it via stdio).
Summary:
FIXTURES_DIRenv var set at compile time so unit tests and integration tests have a unified definitionsrc/test/mod.rstotests/tests_old.rssrc/actions/hover.rsto dedicatedtests/tooltip.rs(harness was setting up and starting an entire server per test so that was an integration-style test anyway)What's still to be done is to unify the way we check both
tests/tests{,_old}.rstest suites in preparation for declarative tests - preferably spawningrlslike in the new suite but use the typed messages from the library, like in the old suite.