This repository has been archived by the owner on Dec 29, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 255
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deduplicates `rustc-ap-*` and uses the v297 version of the libraries instead.
For now this pulls Racer from git to include the racer-rust/racer#1000.
Xanewok
commented
Nov 16, 2018
@@ -219,6 +219,11 @@ pub fn completion_kind_from_match_type(m: racer::MatchType) -> CompletionItemKin | |||
| racer::MatchType::Static => CompletionItemKind::Variable, | |||
racer::MatchType::TypeParameter(_) => CompletionItemKind::TypeParameter, | |||
racer::MatchType::Builtin(_) => CompletionItemKind::Keyword, | |||
racer::MatchType::UseAlias(m) => match m.mtype { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kngwyu do I understand that in this case, we have use X as Y
and we match on Y
but m
here refers to X
and we can derive the completion kind from that instead? (also nested/recursive case seems to be impossible?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it's impossible too but haven't tested it yet.
Xanewok
commented
Nov 16, 2018
All tests pass locally with Rust with rust-lang/rust#55936 applied 🎉 |
nrc
approved these changes
Nov 16, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, thanks!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needs a Racer release including the racer-rust/racer#1000cc @kngwyu
@nrc this has the remaining impls. Still fails on:
but that's until rust-lang/rust#55936 lands, right?