-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relative paths by default. #564
Conversation
Notes from previous discussion of this topic at a team meeting : https://github.com/rust-lang/meeting-minutes/blob/master/weekly-meetings/2014-02-25.md#relative-ref--req-leading--in-use (and here is the ticket that that discussion refers to; this predates the RFC repo so it was a ticket on the rust repo tagged with the RFC label. rust-lang/rust#10910 ) |
@pnkfelix I didn't see that discussion before. However, the resolution of that discussion seems unclear to me. Additionally, I think that doing it this way would help users to better understand modules, since you just have to do everything the same way as you do in a typical file system, but with |
Regardless of the merits of the proposal, I think it is simply too late to make a breaking change of this magnitude. |
@nikomatsakis I believe that my proposal does not break as much code as the Changes in user code would be able to be mostly (if not entirely) automated. Even if there is a lot of non-automate-able changes, you can just add a feature gate for the old behavior. Also note that there aren't any backwards compatibility promises for 1.0 alpha.
Actually, I don't know of any valid reasons not to make this change. (Except if the compiler requires a lot of modification, and I believe that it doesn't) Please correct me if I am wrong. |
There's three. |
-1, changing semantics like this so close to 1.0 might not be a good idea. |
would this mean that modules called |
@yedpodtrzitko IIRC modules named |
@nikomatsakis @sinistersnare I have realized that I misinterpreted the 1.0 alpha compatibility guarantees. I am retracting this RFC. |
Relative-path including reminds me of PHP file including, which is a pain in the neck for me. |
I believe that absolute paths by default in
use
statements are a bad idea.