Promote aarch64-apple-darwin to Tier 1 #3671
Conversation
shepmaster
added
T-lang
|
I'll be honest, I didn't realise this wasn't already tier 1. This seems highly uncontroversial. |
|
I don't see any reason to not kick off this FCP immediately, given the number of people on the FCP. Regarding the specific team set, this is the same set of teams used for the FCP for aarch64-unknown-linux-gnu. @rfcbot fcp merge |
|
Team member @compiler-errors has proposed to merge this. The next step is review by the rest of the tagged team members:
No concerns currently listed. Once a majority of reviewers approve (and at most 2 approvals are outstanding), this will enter its final comment period. If you spot a major issue that hasn't been raised at any point in this process, please speak up! See this document for info about what commands tagged team members can give me. |
rfcbot
added
proposed-final-comment-period
Server availability and cost are my only reservation. Five months is long enough to have data, but we should make sure we are sustainable in the long run, even if our current sponsorships don't continue. I expect the infra team will be able to weigh in on this after consulting with the foundation, so I'll check my box for now and trust that the due diligence will happen. @rfcbot reviewed |
Honestly, I'd expect that as time goes by the problem will not be sourcing aarch64 apple builders, but rather x86_64 apple builders. For example, another CI provider (CircleCI) is already sunsetting x86 apple support, and I expect that GitHub Actions will over time retire their x86 apple runners. |
when and if github retires the x86_64 macOS runners, the question at that point in time would likely (if not definitely) become "should x86_64-apple-darwin still be supported as a tier 1 target?" and the answer to that question would most likely be a no as without the ability to run CI on 64-bit macOS, the rust project cannot adequately test and/or verify that the x86_64 macOS build of Rust will continue to work, unless enough money is collected to build and maintain a self-hosted GitHub Runner, but by that time its highly likely that apple will have dropped support for intel macs completely by then, and by that time it'll likely be time to retire rust's support for x86_64 macOS anyway. but if i had to guess, while macs based on apple silicon are likely the most popular type of mac at this point, github will likely drop their intel mac runners shortly or soon after the last intel-based mac receives its final software update (be it security or final point release or what have you). that's my two cents on the matter, but for now, the intel macOS runner shouldn't be discontinued on github for a while yet. |
No further discussion of removal / deprecation / demotion of x86_64-apple-darwin is needed on this RFC. I'll hide future comments on that topic as I see fit. |
rfcbot
added
final-comment-period
|
🔔 This is now entering its final comment period, as per the review above. 🔔 |
rfcbot
added
finished-final-comment-period
|
The final comment period, with a disposition to merge, as per the review above, is now complete. As the automated representative of the governance process, I would like to thank the author for their work and everyone else who contributed. This will be merged soon. |
There was a problem hiding this comment.
OK, this looks ready to go. I updated the tracking issue to point to rust-lang/rust#73908, since that seems like a convenient place to point this. Thanks for putting up this RFC, @shepmaster.
…imulacrum Promote aarch64-apple-darwin to Tier 1 This promotes aarch64-apple-darwin to Tier 1 status as per rust-lang/rfcs#3671 and tracking issue rust-lang#73908. Not sure what else is necessary for this to impement the aforementioned RFC, however I figured I'd try. I did read in previous issues and PRs that the necessary infrastructure was already in place for the aarch64-apple-darwin target, and the RFC mentions the same. So this should be all thats necessary in order for the target to be promoted. This is a recreation of my previous PR because I accidentally did an incorrect git rebase which caused unnecessary changes to various commit SHAs. So this PR is a recreation of my previous PR without said stumble. My bad.
…imulacrum Promote aarch64-apple-darwin to Tier 1 This promotes aarch64-apple-darwin to Tier 1 status as per rust-lang/rfcs#3671 and tracking issue rust-lang#73908. Not sure what else is necessary for this to impement the aforementioned RFC, however I figured I'd try. I did read in previous issues and PRs that the necessary infrastructure was already in place for the aarch64-apple-darwin target, and the RFC mentions the same. So this should be all thats necessary in order for the target to be promoted. This is a recreation of my previous PR because I accidentally did an incorrect git rebase which caused unnecessary changes to various commit SHAs. So this PR is a recreation of my previous PR without said stumble. My bad.
Rollup merge of rust-lang#128592 - evelynharthbrooke:master, r=Mark-Simulacrum Promote aarch64-apple-darwin to Tier 1 This promotes aarch64-apple-darwin to Tier 1 status as per rust-lang/rfcs#3671 and tracking issue rust-lang#73908. Not sure what else is necessary for this to impement the aforementioned RFC, however I figured I'd try. I did read in previous issues and PRs that the necessary infrastructure was already in place for the aarch64-apple-darwin target, and the RFC mentions the same. So this should be all thats necessary in order for the target to be promoted. This is a recreation of my previous PR because I accidentally did an incorrect git rebase which caused unnecessary changes to various commit SHAs. So this PR is a recreation of my previous PR without said stumble. My bad.
Promote aarch64-apple-darwin to Tier 1 This promotes aarch64-apple-darwin to Tier 1 status as per rust-lang/rfcs#3671 and tracking issue #73908. Not sure what else is necessary for this to impement the aforementioned RFC, however I figured I'd try. I did read in previous issues and PRs that the necessary infrastructure was already in place for the aarch64-apple-darwin target, and the RFC mentions the same. So this should be all thats necessary in order for the target to be promoted. This is a recreation of my previous PR because I accidentally did an incorrect git rebase which caused unnecessary changes to various commit SHAs. So this PR is a recreation of my previous PR without said stumble. My bad.
Rendered