Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid non-local definitions in functions #3373

Merged
merged 12 commits into from
Jan 26, 2024
Merged

Avoid non-local definitions in functions #3373

merged 12 commits into from
Jan 26, 2024

Commits on Jan 20, 2023

  1. Avoid non-local definitions in functions

    @joshtriplett
    joshtriplett committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    09a0e24 View commit details
    Browse the repository at this point in the history

  2. Set RFC number

    @joshtriplett
    joshtriplett committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    632d8c9 View commit details
    Browse the repository at this point in the history

  3. Clarify that tools don't *have* to be looking for these definitions

    @joshtriplett
    joshtriplett committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    5d5304e View commit details
    Browse the repository at this point in the history

  4. Address closures as well

    @joshtriplett
    joshtriplett committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    85c7849 View commit details
    Browse the repository at this point in the history

  5. Note that no other language feature has this issue

    @joshtriplett
    joshtriplett committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    c29d41c View commit details
    Browse the repository at this point in the history

  6. Address macros

    @joshtriplett
    joshtriplett committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    22ac798 View commit details
    Browse the repository at this point in the history

  7. Handle other expression-containing items (static, const, enum discrim… 

    …inants)
    @joshtriplett
    joshtriplett committed Jan 20, 2023
    Configuration menu
    Copy the full SHA
    66ef463 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2024

  1. 3373: Change to a warn-by-default lint

    @joshtriplett
    joshtriplett committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    218949d View commit details
    Browse the repository at this point in the history

  2. 3373: Add prior art

    @joshtriplett
    joshtriplett committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    d1e9965 View commit details
    Browse the repository at this point in the history

  3. 3373: Define which token the lint attaches to

    @joshtriplett
    joshtriplett committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    01045be View commit details
    Browse the repository at this point in the history

  4. 3373: Allow definitions in anonymous const items

    @joshtriplett
    joshtriplett committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    4d28f57 View commit details
    Browse the repository at this point in the history

  5. 3373: Add unresolved question about anonymous const items

    @joshtriplett
    joshtriplett committed Jan 3, 2024
    Configuration menu
    Copy the full SHA
    e2ae261 View commit details
    Browse the repository at this point in the history