Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adds async stream rfc #2996

Closed
wants to merge 47 commits into from
Closed

adds async stream rfc #2996

wants to merge 47 commits into from

Commits on Sep 26, 2020

  1. adds async stream rfc 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    8152e62 View commit details
    Browse the repository at this point in the history

  2. remove boilerplate questions 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Sep 26, 2020
    Configuration menu
    Copy the full SHA
    310b0b3 View commit details
    Browse the repository at this point in the history

Commits on Sep 29, 2020

  1. Update text/0000-async-stream.md 

    Co-authored-by: Florian Gilcher <[email protected]>
    @nellshamrell @skade
    nellshamrell and skade authored Sep 29, 2020
    Configuration menu
    Copy the full SHA
    16c4870 View commit details
    Browse the repository at this point in the history

  2. Update text/0000-async-stream.md 

    Co-authored-by: Florian Gilcher <[email protected]>
    @nellshamrell @skade
    nellshamrell and skade authored Sep 29, 2020
    Configuration menu
    Copy the full SHA
    20a064b View commit details
    Browse the repository at this point in the history

  3. Update text/0000-async-stream.md 

    Co-authored-by: Waffle Lapkin <[email protected]>
    @nellshamrell @WaffleLapkin
    nellshamrell and WaffleLapkin authored Sep 29, 2020
    Configuration menu
    Copy the full SHA
    5a3de0f View commit details
    Browse the repository at this point in the history

  4. Update text/0000-async-stream.md 

    Co-authored-by: kennytm <[email protected]>
    @nellshamrell @kennytm
    nellshamrell and kennytm authored Sep 29, 2020
    Configuration menu
    Copy the full SHA
    a145be9 View commit details
    Browse the repository at this point in the history

  5. Update text/0000-async-stream.md 

    Co-authored-by: Taiki Endo <[email protected]>
    @nellshamrell @taiki-e
    nellshamrell and taiki-e authored Sep 29, 2020
    Configuration menu
    Copy the full SHA
    f65f099 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2020

  1. adds more information about coverting an iterator into a stream 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    e0d66d4 View commit details
    Browse the repository at this point in the history

  2. adds clarifying statement regarding !Unpin streams 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Oct 1, 2020
    Configuration menu
    Copy the full SHA
    7b84d1c View commit details
    Browse the repository at this point in the history

Commits on Oct 17, 2020

  1. corrects some typos 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Oct 17, 2020
    Configuration menu
    Copy the full SHA
    512f41a View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2020

  1. adds clarification around motivation and the guide level explanation 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Nov 14, 2020
    Configuration menu
    Copy the full SHA
    0e44c56 View commit details
    Browse the repository at this point in the history

Commits on Nov 18, 2020

  1. Update text/0000-async-stream.md 

    Co-authored-by: Taiki Endo <[email protected]>
    @nellshamrell @taiki-e
    nellshamrell and taiki-e authored Nov 18, 2020
    Configuration menu
    Copy the full SHA
    c7ace16 View commit details
    Browse the repository at this point in the history

  2. Update text/0000-async-stream.md 

    Co-authored-by: Taiki Endo <[email protected]>
    @nellshamrell @taiki-e
    nellshamrell and taiki-e authored Nov 18, 2020
    Configuration menu
    Copy the full SHA
    1948fad View commit details
    Browse the repository at this point in the history

  3. Update text/0000-async-stream.md 

    Co-authored-by: Taiki Endo <[email protected]>
    @nellshamrell @taiki-e
    nellshamrell and taiki-e authored Nov 18, 2020
    Configuration menu
    Copy the full SHA
    0ba1e67 View commit details
    Browse the repository at this point in the history

  4. Update text/0000-async-stream.md 

    Co-authored-by: Taiki Endo <[email protected]>
    @nellshamrell @taiki-e
    nellshamrell and taiki-e authored Nov 18, 2020
    Configuration menu
    Copy the full SHA
    414665a View commit details
    Browse the repository at this point in the history

  5. Update text/0000-async-stream.md 

    Co-authored-by: Taiki Endo <[email protected]>
    @nellshamrell @taiki-e
    nellshamrell and taiki-e authored Nov 18, 2020
    Configuration menu
    Copy the full SHA
    fc92f81 View commit details
    Browse the repository at this point in the history

  6. adds examples of how a user would interact with the poll_next and nex… 

    …t methods

Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    6f6da39 View commit details
    Browse the repository at this point in the history

  7. Update text/0000-async-stream.md 

    Co-authored-by: Taiki Endo <[email protected]>
    @nellshamrell @taiki-e
    nellshamrell and taiki-e authored Nov 18, 2020
    Configuration menu
    Copy the full SHA
    c7af682 View commit details
    Browse the repository at this point in the history

  8. adds in more discussion around pinning with async generators 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Nov 18, 2020
    Configuration menu
    Copy the full SHA
    a1b60e8 View commit details
    Browse the repository at this point in the history

  9. Update text/0000-async-stream.md 

    Co-authored-by: Taiki Endo <[email protected]>
    @nellshamrell @taiki-e
    nellshamrell and taiki-e authored Nov 18, 2020
    Configuration menu
    Copy the full SHA
    0b806ef View commit details
    Browse the repository at this point in the history

Commits on Dec 2, 2020

  1. correct reference to Future::poll method 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    ece4f4c View commit details
    Browse the repository at this point in the history

  2. combines both next method sections 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    8b52cee View commit details
    Browse the repository at this point in the history

  3. adds examples for addressing !Unpin streams 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    174e218 View commit details
    Browse the repository at this point in the history

  4. add more clarification to try_next method 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    3fe320e View commit details
    Browse the repository at this point in the history

  5. Update text/0000-async-stream.md 

    Co-authored-by: Tyler Mandry <[email protected]>
    @nellshamrell @tmandry
    nellshamrell and tmandry authored Dec 2, 2020
    Configuration menu
    Copy the full SHA
    ec04b64 View commit details
    Browse the repository at this point in the history

  6. Update text/0000-async-stream.md 

    Co-authored-by: Tyler Mandry <[email protected]>
    @nellshamrell @tmandry
    nellshamrell and tmandry authored Dec 2, 2020
    Configuration menu
    Copy the full SHA
    0ed3963 View commit details
    Browse the repository at this point in the history

  7. Update text/0000-async-stream.md 

    Co-authored-by: Tyler Mandry <[email protected]>
    @nellshamrell @tmandry
    nellshamrell and tmandry authored Dec 2, 2020
    Configuration menu
    Copy the full SHA
    c54ca85 View commit details
    Browse the repository at this point in the history

  8. addresses some suggestions from comments on the RFC 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    a39d5c3 View commit details
    Browse the repository at this point in the history

  9. clarify wording around resuming iteration once a Stream returns None 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Dec 2, 2020
    Configuration menu
    Copy the full SHA
    0ee1505 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2020

  1. Update text/0000-async-stream.md 

    Co-authored-by: Tyler Mandry <[email protected]>
    @nellshamrell @tmandry
    nellshamrell and tmandry authored Dec 3, 2020
    Configuration menu
    Copy the full SHA
    1e4cc8c View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2020

  1. removes unneeded template text 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    ec1b422 View commit details
    Browse the repository at this point in the history

  2. Update text/0000-async-stream.md 

    Co-authored-by: Tyler Mandry <[email protected]>
    @nellshamrell @tmandry
    nellshamrell and tmandry authored Dec 6, 2020
    Configuration menu
    Copy the full SHA
    7bf481d View commit details
    Browse the repository at this point in the history

  3. add possiblity of custom compiler error message when requiring users … 

    …to upgrade futures

Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    8c42458 View commit details
    Browse the repository at this point in the history

  4. adds note that lending streams depend on Generic Associated Types 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    e0647fe View commit details
    Browse the repository at this point in the history

  5. Update text/0000-async-stream.md 

    Co-authored-by: Tyler Mandry <[email protected]>
    @nellshamrell @tmandry
    nellshamrell and tmandry authored Dec 6, 2020
    Configuration menu
    Copy the full SHA
    3367344 View commit details
    Browse the repository at this point in the history

  6. Update text/0000-async-stream.md 

    Co-authored-by: Tyler Mandry <[email protected]>
    @nellshamrell @tmandry
    nellshamrell and tmandry authored Dec 6, 2020
    Configuration menu
    Copy the full SHA
    418ccd6 View commit details
    Browse the repository at this point in the history

  7. Update text/0000-async-stream.md 

    Co-authored-by: Tyler Mandry <[email protected]>
    @nellshamrell @tmandry
    nellshamrell and tmandry authored Dec 6, 2020
    Configuration menu
    Copy the full SHA
    997d698 View commit details
    Browse the repository at this point in the history

  8. Update text/0000-async-stream.md 

    Co-authored-by: Tyler Mandry <[email protected]>
    @nellshamrell @tmandry
    nellshamrell and tmandry authored Dec 6, 2020
    Configuration menu
    Copy the full SHA
    b7d2cef View commit details
    Browse the repository at this point in the history

  9. Update text/0000-async-stream.md 

    Co-authored-by: Jon Gjengset <[email protected]>
    @nellshamrell @jonhoo
    nellshamrell and jonhoo authored Dec 6, 2020
    Configuration menu
    Copy the full SHA
    88f1e1a View commit details
    Browse the repository at this point in the history

  10. Update text/0000-async-stream.md 

    Co-authored-by: Tyler Mandry <[email protected]>
    @nellshamrell @tmandry
    nellshamrell and tmandry authored Dec 6, 2020
    Configuration menu
    Copy the full SHA
    dad7612 View commit details
    Browse the repository at this point in the history

  11. Update text/0000-async-stream.md 

    Co-authored-by: Tyler Mandry <[email protected]>
    @nellshamrell @tmandry
    nellshamrell and tmandry authored Dec 6, 2020
    Configuration menu
    Copy the full SHA
    d8c8d00 View commit details
    Browse the repository at this point in the history

  12. add in draft of LendingStream trait 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Dec 6, 2020
    Configuration menu
    Copy the full SHA
    1ae8276 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2020

  1. Update text/0000-async-stream.md 

    Co-authored-by: Tyler Mandry <[email protected]>
    @nellshamrell @tmandry
    nellshamrell and tmandry authored Dec 8, 2020
    Configuration menu
    Copy the full SHA
    fef7748 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2020

  1. Update text/0000-async-stream.md 

    Co-authored-by: Tyler Mandry <[email protected]>
    @nellshamrell @tmandry
    nellshamrell and tmandry authored Dec 9, 2020
    Configuration menu
    Copy the full SHA
    881b162 View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. revert wording around streams resuming iteration 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    1e2d669 View commit details
    Browse the repository at this point in the history

  2. removes unnecessary link formatting 

    Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Dec 15, 2020
    Configuration menu
    Copy the full SHA
    d749f41 View commit details
    Browse the repository at this point in the history

Commits on Jan 10, 2021

  1. removes the next method from this RFC and moves it to the future poss… 

    …iblities section

Signed-off-by: Nell Shamrell <[email protected]>
    @nellshamrell
    nellshamrell committed Jan 10, 2021
    Configuration menu
    Copy the full SHA
    de606aa View commit details
    Browse the repository at this point in the history