Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add 'How We Teach This' to template, per RFC 1636. #1810

Merged
merged 2 commits into from
Dec 13, 2016

Conversation

chriskrycho
Copy link
Contributor

@chriskrycho chriskrycho commented Dec 7, 2016

You have taken your first step into a larger world (of new features—and some old ones—being documented)!

first-step

Implements the required change to the RFC template per #1636.

@carols10cents
Copy link
Member

carols10cents commented Dec 7, 2016

I have no idea how important this is, but it looks like the other parts of the template have lines hard-wrapped at 100 chars grapheme clusters?

@chriskrycho
Copy link
Contributor Author

chriskrycho commented Dec 7, 2016

I'm happy to wrap it; I totally missed that (I saw soft wrapping in my editor and thought it wasn't wrapped at all). Also the README is wrapped at a mix of what looks like 80 and 72 or something. ¯\_(ツ)_/¯ Some direction welcome.

@carols10cents
Copy link
Member

rust-lang/style-team#1

😂😂😂😂

@Ericson2314
Copy link
Contributor

Ericson2314 commented Dec 7, 2016

Talking about line width reminded me to open #1811

@aturon
Copy link
Member

aturon commented Dec 13, 2016

Merging. Huzzah!

@aturon aturon merged commit cac791d into rust-lang:master Dec 13, 2016
@chriskrycho chriskrycho deleted the implement-rfc-1636 branch December 23, 2016 19:07
hadronized pushed a commit to hadronized/rfcs that referenced this pull request Feb 10, 2017
Add 'How We Teach This' to template, per RFC 1636.
@Centril Centril added the A-meta Proposals about how we make proposals label Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-meta Proposals about how we make proposals
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants