-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend Cell to non-Copy types #1651
Merged
Merged
Changes from 2 commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
- Feature Name: move_cell | ||
- Start Date: 2016-06-15 | ||
- RFC PR: (leave this empty) | ||
- Rust Issue: (leave this empty) | ||
|
||
# Summary | ||
[summary]: #summary | ||
|
||
Extend `Cell` to work with non-`Copy` types. | ||
|
||
# Motivation | ||
[motivation]: #motivation | ||
|
||
It allows safe inner-mutability of non-`Copy` types without the overhead of `RefCell`'s reference counting. | ||
|
||
# Detailed design | ||
[design]: #detailed-design | ||
|
||
```rust | ||
impl<T> Cell<T> { | ||
fn set(&self, val: T); | ||
fn replace(&self, val: T) -> T; | ||
fn into_inner(self) -> T; | ||
} | ||
|
||
impl<T: Copy> Cell<T> { | ||
fn get(&self); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
|
||
} | ||
|
||
impl<T: Default> Cell<T> { | ||
fn take(&self) -> T; | ||
} | ||
``` | ||
|
||
The `get` method is kept but is only available for `T: Copy`. The `set` method is available for all `T`. | ||
|
||
The `into_inner` and `replace` methods are added, which allow the value in a cell to be read even if `T` is not `Copy`. The `get` method can't be used since the cell must always contain a valid value. | ||
|
||
Finally, a `take` method is added which is equivalent to `self.replace(Default::default())`. | ||
|
||
# Drawbacks | ||
[drawbacks]: #drawbacks | ||
|
||
It makes the `Cell` type more complicated. | ||
|
||
# Alternatives | ||
[alternatives]: #alternatives | ||
|
||
The alternative is to use the `MoveCell` type from crates.io which provides the same functionality. | ||
|
||
# Unresolved questions | ||
[unresolved]: #unresolved-questions | ||
|
||
None |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which types? What is a concrete use case for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/SimonSapin/kuchiki/blob/23e92d45b7406865e035defdc5f5ca9f1809c406/src/tree.rs#L116 is the best example I could find with a quick search.