This repository has been archived by the owner on Sep 30, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 340
Update the list of personal characteristics to synchronize with the Contributor's Covenant v1.3 #288
Merged
nikomatsakis
merged 3 commits into
rust-lang:master
from
nikomatsakis:sync-contrib-covenant
Jan 22, 2016
Merged
Update the list of personal characteristics to synchronize with the Contributor's Covenant v1.3 #288
nikomatsakis
merged 3 commits into
rust-lang:master
from
nikomatsakis:sync-contrib-covenant
Jan 22, 2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor's Covenant v1.3, found at <http://contributor-covenant.org/version/1/3/0/>.
👍 from me |
👍 |
Sounds good to me, thanks @nikomatsakis! |
nikomatsakis
force-pushed
the
sync-contrib-covenant
branch
from
January 21, 2016 17:04
d0aaf5e
to
7189564
Compare
cc @Charlotteis Strong 👍 for me. I like being more explicit, and especially the addition of "level of experience". I also think sync'ing with the current best practices here is a good way to go. |
Lgtm. Thanks @nikomatsakis |
👍 |
+1 |
looks fine with me. (at first I thought "gender, gender ..." was a typo, but I can understand differentiating between "gender" and "gender identity/expression") |
👍 |
1 similar comment
👍 |
OK, at this point everyone on the core team (and many on the mod team) have either commented here or spoken with me privately and approved this PR. Therefore, I am going to merge it. Thanks all! |
nikomatsakis
added a commit
that referenced
this pull request
Jan 22, 2016
Update the list of personal characteristics to synchronize with the Contributor's Covenant v1.3
🎉 🎊 🎉 |
zkat
added a commit
to zkat/node
that referenced
this pull request
Jan 22, 2016
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: nodejs#4801 Fixes: nodejs/inclusivity#82
zkat
added a commit
to nodejs/node
that referenced
this pull request
Jan 22, 2016
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: #4801 Fixes: nodejs/inclusivity#82
rvagg
pushed a commit
to nodejs/node
that referenced
this pull request
Jan 25, 2016
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: #4801 Fixes: nodejs/inclusivity#82
MylesBorins
pushed a commit
to nodejs/node
that referenced
this pull request
Jan 28, 2016
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: #4801 Fixes: nodejs/inclusivity#82
MylesBorins
pushed a commit
to nodejs/node
that referenced
this pull request
Feb 11, 2016
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: #4801 Fixes: nodejs/inclusivity#82
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 11, 2016
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: nodejs#4801 Fixes: nodejs/inclusivity#82
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 13, 2016
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: nodejs#4801 Fixes: nodejs/inclusivity#82
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Feb 15, 2016
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: nodejs#4801 Fixes: nodejs/inclusivity#82
scovetta
pushed a commit
to scovetta/node
that referenced
this pull request
Apr 2, 2016
rust-lang/prev.rust-lang.org#288 landed in the Rust repo so it seems like a good idea to just bring the updated list in. We also received a request to do this in nodejs/inclusivity#82 so this should resolve that. Thanks to [@Charlotteis](https://github.com/Charlotteis) for bringing up the original issue. Reviewed-By: Jeremiah Senkpiel <[email protected]> Reviewed-By: Myles Borins <[email protected]> Reviewed-By: James M Snell <[email protected]> Reviewed-By: Сковорода Никита Андреевич <[email protected]> PR-URL: nodejs#4801 Fixes: nodejs/inclusivity#82
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the list of personal characteristics to synchronize with the Contributor's Covenant v1.3. This is not intended as a change to the actual meaning of the CoC, since all of these characteristics were intended to be implied by the original wording. However, making the list more explicit is clearer for readers overall, and the CC seems to have a reasonable list.
r? @rust-lang/core
cc @rust-lang/moderation
UPDATE: Tweaked wording of this PR proposal somewhat.
UPDATE from @aturon: For reference, here's the announcement we sent out to the community: