Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some common shuffles #98
Add some common shuffles #98
Changes from 1 commit
977f26f
1999c54
7028a58
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should address the case of lane numbering ("are we indexing from zero or one?") explicitly here if we are going to use "even" or "odd". Likewise, "upper" and "lower" need an explicit meaning.
"Interleave" feels slightly uncommon as a vocabulary word, even though it is a technically correct term, so in the documentation itself consider using "alternating" to describe this phenomenon: as-is, going by these remarks, I have to visualize the elements moving before I realize it is in fact alternating.
I don't thiiink I would want to use "zip" like Arm does to describe this, but am unsure.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, I agree that all of those definitions are a little vague. There's probably a clearer way to describe it, but I'm not sure what that is.