build: Fix build after rust-lang/rust#60951 #852
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RalfJung
reviewed
Jul 24, 2019
|
Other than this nit, looks good. Thanks! |
|
I removed the second commit (to force to use 2018 edition idioms). |
|
That also works. I am still in favor of using 2018 idioms, I just don't like warnings to stop things from compiling when I am developing. So I'd be happy if you could re-submit that commit, with my comments applied, as a new PR. :) |
|
@bors r+ |
|
📌 Commit fd71fbe has been approved by |
bors
added a commit
that referenced
this pull request
Jul 24, 2019
build: Fix build after rust-lang/rust#60951
|
💔 Test failed - checks-travis |
|
Timeout on macOS. @bors retry |
bors
added a commit
that referenced
this pull request
Jul 24, 2019
build: Fix build after rust-lang/rust#60951
|
☀️ Test successful - checks-travis, status-appveyor |
bors
added a commit
that referenced
this pull request
Jul 24, 2019
build: Warn if not use 2018 idioms As requested in #852 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.