Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use deref_pointer_as instead of deref_pointer #4140

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

geetanshjuneja
Copy link
Contributor

@geetanshjuneja geetanshjuneja commented Jan 17, 2025

Links to #3841.

This PR is still under progress.

src/shims/time.rs Outdated Show resolved Hide resolved
src/shims/unix/foreign_items.rs Outdated Show resolved Hide resolved
src/shims/unix/fs.rs Outdated Show resolved Hide resolved
src/shims/unix/unnamed_socket.rs Show resolved Hide resolved
@geetanshjuneja
Copy link
Contributor Author

geetanshjuneja commented Jan 18, 2025

@RalfJung since libc isn't reliably available on Windows targets, I won't be able to get windows specificlayouts like this.libc_ty_layout("CONSOLE_SCREEN_BUFFER_INFO"). What should I do in this case?

@RalfJung
Copy link
Member

Yeah CONSOLE_SCREEN_BUFFER_INFO is not in libc. It's a Windows API type. I'd say remove that one from the PR for now and open a Zulip thread; either we can find this type declaration somewhere else or we have to write some helpers to declare such struct types entirely ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants