Use the symbol_name query instead of trying to infer from the link_name attribute #3724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me attribute This prevents the calculated name from going out of sync with exported_symbols. It also avoids having to special case the panic_impl lang item.
bjorn3
force-pushed
the
use_symbol_name_query
branch
from
8ab5755 to
332db9a
Compare
RalfJung
reviewed
Jul 1, 2024
RalfJung
reviewed
Jul 1, 2024
|
@bors r+ |
|
☀️ Test successful - checks-actions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prevents the calculated name from going out of sync with exported_symbols. It also avoids having to special case the panic_impl lang item.
It also makes it easier to fix miri with rust-lang/rust#127173.