Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix compile_fail doctests with post-mono errors #3392

Merged
merged 1 commit into from
Mar 20, 2024
Merged

fix compile_fail doctests with post-mono errors #3392

merged 1 commit into from
Mar 20, 2024

Conversation

RalfJung
Copy link
Member

Fixes #2423

@RalfJung RalfJung mentioned this pull request Mar 19, 2024
Closed
@RalfJung
Copy link
Member Author

Hm, judging from the failure in rust-lang/rust#122744, it seems like calling collect_and_partition_mono_items when the dependencies are metadata-only may run into problems...

@oli-obk
Copy link
Contributor

oli-obk commented Mar 20, 2024

We won't run into that specific problem as we -Zalways-emit-mir

@bors r+

@bors
Copy link
Contributor

bors commented Mar 20, 2024

📌 Commit 010d1d7 has been approved by oli-obk

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 20, 2024

⌛ Testing commit 010d1d7 with merge 586af60...

bors added a commit that referenced this pull request Mar 20, 2024
@bors
Auto merge of #3392 - RalfJung:post-mono, r=oli-obk
586af60 
fix compile_fail doctests with post-mono errors

Fixes #2423
@RalfJung
Copy link
Member Author

We won't run into that specific problem as we -Zalways-emit-mir

Ah!

But only for target crates. Let me adjust the PR.
@bors r-

@bors
Copy link
Contributor

bors commented Mar 20, 2024

☀️ Try build successful - checks-actions
Build commit: 586af60 (586af60079f4d7de0c48989c646504ef31649070)

@RalfJung
run full mono-item collection on all MIRI_BE_RUSTC=target builds
73ba941 
this fixes compile_fail doctests with post-mono errors
@RalfJung RalfJung mentioned this pull request Mar 20, 2024
Open
@RalfJung
Copy link
Member Author

@bors r=oli-obk

@bors
Copy link
Contributor

bors commented Mar 20, 2024

📌 Commit 73ba941 has been approved by oli-obk

It is now in the queue for this repository.

@bors
Copy link
Contributor

bors commented Mar 20, 2024

⌛ Testing commit 73ba941 with merge addad82...

@bors
Copy link
Contributor

bors commented Mar 20, 2024

☀️ Test successful - checks-actions
Approved by: oli-obk
Pushing addad82 to master...

@bors bors merged commit addad82 into rust-lang:master Mar 20, 2024
8 checks passed
@RalfJung RalfJung deleted the post-mono branch March 20, 2024 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

compile_fail doctests that rely on post-monomorphization errors don't pass miri test
3 participants
@RalfJung @oli-obk @bors