Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sync primitives #1362

Merged
merged 17 commits into from
May 25, 2020
Merged

Add sync primitives #1362

merged 17 commits into from
May 25, 2020

Conversation

vakaras
Copy link
Contributor

@vakaras vakaras commented Apr 24, 2020

This is a follow up PR for #1284 that adds support for the missing synchronization primitives.

Sorry for flooding with PRs, but my internship is coming to an end and I need to get things out.

Fixes #1419

src/sync.rs Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/shims/sync.rs Outdated Show resolved Hide resolved
@bors

This comment has been minimized.

src/machine.rs Outdated Show resolved Hide resolved
src/thread.rs Outdated Show resolved Hide resolved
src/thread.rs Outdated Show resolved Hide resolved
src/thread.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/thread.rs Outdated Show resolved Hide resolved
src/sync.rs Outdated Show resolved Hide resolved
src/thread.rs Outdated Show resolved Hide resolved
src/shims/sync.rs Outdated Show resolved Hide resolved
src/thread.rs Outdated Show resolved Hide resolved
@RalfJung
Copy link
Member

Looking good, all nits resolved. :) Thanks a lot!

Please rebase, and squash the niting in the end to a few commits. (No need to have a beautiful history but 66 commits is a bit much.)

@vakaras
Copy link
Contributor Author

vakaras commented May 25, 2020

It seems that 200ms is a too small range for a timeout.

@RalfJung
Copy link
Member

Looking great, thank you so much. :)
@bors r+

@bors
Copy link
Contributor

bors commented May 25, 2020

📌 Commit 34ddd77 has been approved by RalfJung

@bors
Copy link
Contributor

bors commented May 25, 2020

⌛ Testing commit 34ddd77 with merge bfe030d...

@bors
Copy link
Contributor

bors commented May 25, 2020

☀️ Test successful - checks-travis, status-appveyor
Approved by: RalfJung
Pushing bfe030d to master...

@bors bors merged commit bfe030d into rust-lang:master May 25, 2020
@jonhoo
Copy link

jonhoo commented May 25, 2020

Oh boy oh boy oh boy! After you've merged all your changes @vakaras, any chance you could do a little write-up to demonstrate what now works in miri?

@RalfJung
Copy link
Member

I plan to write a blog post once my thesis is finally submitted (~2 weeks), mentioning all the things that landed in the last 6 months or so (panics, file system access, cross-target-execution, concurrency... there's probably more and there are some minor but notable things I still plan to do before the post) but of course I'd happily link to a more detailed write-up about the concurrency parts. :D

@vakaras
Copy link
Contributor Author

vakaras commented May 25, 2020

Oh boy oh boy oh boy! After you've merged all your changes @vakaras, any chance you could do a little write-up to demonstrate what now works in miri?

Not earlier than in the next three weeks because I need to get Prusti working again as soon as possible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix UB checking for Mutex misusage
5 participants