-
Notifications
You must be signed in to change notification settings - Fork 349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add sync primitives #1362
Add sync primitives #1362
Conversation
This comment has been minimized.
This comment has been minimized.
bc5d55d
to
dc761b9
Compare
Looking good, all nits resolved. :) Thanks a lot! Please rebase, and squash the niting in the end to a few commits. (No need to have a beautiful history but 66 commits is a bit much.) |
4c6cd88
to
dec2057
Compare
It seems that 200ms is a too small range for a timeout. |
Looking great, thank you so much. :) |
📌 Commit 34ddd77 has been approved by |
☀️ Test successful - checks-travis, status-appveyor |
Oh boy oh boy oh boy! After you've merged all your changes @vakaras, any chance you could do a little write-up to demonstrate what now works in miri? |
I plan to write a blog post once my thesis is finally submitted (~2 weeks), mentioning all the things that landed in the last 6 months or so (panics, file system access, cross-target-execution, concurrency... there's probably more and there are some minor but notable things I still plan to do before the post) but of course I'd happily link to a more detailed write-up about the concurrency parts. :D |
This is a follow up PR for #1284 that adds support for the missing synchronization primitives.
Sorry for flooding with PRs, but my internship is coming to an end and I need to get things out.
Fixes #1419