Refactor ptr_offset_inbounds #1031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 5, 2019
let caller of check_ptr_access_align control the error message This is needed for rust-lang/miri#1031
Centril
added a commit
to Centril/rust
that referenced
this pull request
Nov 6, 2019
let caller of check_ptr_access_align control the error message This is needed for rust-lang/miri#1031
|
@bors r+ |
|
📌 Commit b2a2f4d has been approved by |
bors
added a commit
that referenced
this pull request
Nov 6, 2019
Refactor ptr_offset_inbounds I finally found a way to write this using basically just `check_ptr_access` while handling all cases (integers and pointers, offset 0 or not) correctly. This changes behavior for NULL ptrs, but I think the change is for the better. Depends on rust-lang/rust#66081.
|
💔 Test failed - status-appveyor |
|
Ah, I forgot about negative offsets. @bors r+ |
|
📌 Commit 8b0c14f has been approved by |
bors
added a commit
that referenced
this pull request
Nov 6, 2019
Refactor ptr_offset_inbounds I finally found a way to write this using basically just `check_ptr_access` while handling all cases (integers and pointers, offset 0 or not) correctly. This changes behavior for NULL ptrs, but I think the change is for the better. Depends on rust-lang/rust#66081.
|
☀️ Test successful - checks-travis, status-appveyor |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I finally found a way to write this using basically just
check_ptr_accesswhile handling all cases (integers and pointers, offset 0 or not) correctly. This changes behavior for NULL ptrs, but I think the change is for the better.Depends on rust-lang/rust#66081.