Skip to content

Commit

Permalink
Auto merge of #119129 - jyn514:verbose, r=compiler-errors,estebank
Browse files Browse the repository at this point in the history
rework `-Zverbose`

implements the changes described in rust-lang/compiler-team#706

the first commit is only a name change from `-Zverbose` to `-Zverbose-internals` and does not change behavior. the second commit changes diagnostics.

possible follow up work:
- `ty::pretty` could print more info with `--verbose` than it does currently. `-Z verbose-internals` shows too much info in a way that's not helpful to users. michael had ideas about this i didn't fully understand: https://rust-lang.zulipchat.com/#narrow/stream/233931-t-compiler.2Fmajor-changes/topic/uplift.20some.20-Zverbose.20calls.20and.20rename.20to.E2.80.A6.20compiler-team.23706/near/408984200
- `--verbose` should imply `-Z write-long-types-to-disk=no`. the code in `ty_string_with_limit` should take `--verbose` into account (apparently this affects `Ty::sort_string`, i'm not familiar with this code). writing a file to disk should suggest passing `--verbose`.

r? `@compiler-errors` cc `@estebank`
  • Loading branch information
bors committed Dec 26, 2023
2 parents 4a223b9 + e3a582b commit cf98a54
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit cf98a54

Please sign in to comment.