Skip to content

Commit

Permalink
Rollup merge of #120159 - jyn514:track-verbose, r=wesleywiser
Browse files Browse the repository at this point in the history
Track `verbose` and `verbose_internals`

`verbose_internals` has been UNTRACKED since it was introduced. When i added `verbose` in rust-lang/rust#119129 i made it UNTRACKED as well.

``@bjorn3`` says: rust-lang/rust#119286 (comment)
> On errors we don't finalize the incr comp cache, but non-fatal diagnostics are cached afaik.
Otherwise we would have to replay the query in question, which we may not be able to do if the query key is not reconstructible from the dep node fingerprint.

So we must track these flags to avoid replaying incorrect diagnostics.

r? incremental
  • Loading branch information
matthiaskrgr authored Jan 22, 2024
2 parents 4862cbb + 1dae551 commit 3140352
Showing 0 changed files with 0 additions and 0 deletions.

0 comments on commit 3140352

Please sign in to comment.