Make print page (print.html) links link to anchors on the print page #1738
Conversation
HollowMan6
force-pushed
the
master
branch
7 times, most recently
from
39ffbc0
to
e3cca8f
Compare
|
Tested on the following Rust Bookshelf books with the js code here checking broken links also unavailable anchors on With this PR now all the links on the print page are self-contained, no broken links found except for those who are broken originally, or has self-made JavaScript that needs adaptation (ferris.js in Rust Programming Language).
Please review, Will appreciate if this PR can be merged. cc: @ehuss |
HollowMan6
force-pushed
the
master
branch
2 times, most recently
from
713c825
to
a1bf5cb
Compare
|
This was very helpful for me, it would be nice if this could be merged so i didn't have to build HollowMan6's fork myself in order to generate PDFs whose internal links work |
HollowMan6
force-pushed
the
master
branch
3 times, most recently
from
f1ceb69
to
38ecc41
Compare
ehuss
added
the
S-waiting-on-author
HollowMan6
force-pushed
the
master
branch
2 times, most recently
from
57db987
to
00d56ab
Compare
|
Hi @ehuss , I've noticed that you added the S-waiting-on-author label to this PR recently, but I can't see any code change requests and even reviews for this PR. Am I missing something and what should I response/clarify? |
I'm so sorry. I had a partial review that I wrote a long time ago, but never finished and didn't click the submit button. But GitHub displays the review on the conversation page as-if it was submitted (with a little icon that I overlooked), so I thought I had submitted it. |
Done! Thanks for reviewing. Would love to see it get merged in the near future. |
|
i'm using hallowman fork to create pdf files now. waiting for this branch to move to master. |
|
Hi, @ehuss! It took me some time to resolve the conflicts this time, so I hope this can get merged soon, any plans for continue reviewing? |
|
Thanks. We will review it when we get the time so don't worry :) |
HollowMan6
force-pushed
the
master
branch
2 times, most recently
from
c4e9a93
to
edf3067
Compare
|
I checked the broken links again with the methods described at: #1738 (comment) and fixed the following issues:
Now no other broken links are found with the current version. |
|
Should we change the label to S-waiting-on-review ? |
Dylan-DPC
added
S-waiting-on-review
Signed-off-by: Hollow Man <[email protected]>
Let all the anchors id on the print page to have a path id prefix to help locate. e.g. bar/foo.md#abc -> #bar-foo-abc Also append a dummy div to the start of the original page to make sure that original page links without an anchor can also be located. Fix to remove all the `./` in the normalized path id so that for "./foo/bar.html#abc" we still get "#foo-bar-abc" Add support for redirect link anchors in print page so that anchors can also be redirected, also handle URL redirect links on print page Handle all the elements id to add a path prefix, also make path id to all be the lower case Fix for print page footnote links by adding the path id prefix Signed-off-by: Hollow Man <[email protected]>
Resolves #1736
Let all the anchors id on the print page to have a path id prefix to
help locate.
e.g. bar/foo.md#abc -> #bar-foo-abc
Also append a dummy div to the start of the original page to make sure
that original page links without an anchor can also be located.
Signed-off-by: Hollow Man [email protected]