Loosen orderings for logger initialization #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KodrAus
commented
Jun 25, 2024
| @@ -341,10 +341,6 @@ | |||
| #![warn(missing_docs)] | |||
| #![deny(missing_debug_implementations, unconditional_recursion)] | |||
| #![cfg_attr(all(not(feature = "std"), not(test)), no_std)] | |||
| // When compiled for the rustc compiler itself we want to make sure that this is | |||
| // an unstable crate | |||
| #![cfg_attr(rustbuild, feature(staged_api, rustc_private))] | |||
There was a problem hiding this comment.
I believe this is a left-over. As far as I know log isn't used in the compiler anymore, but will actually go and check.
There was a problem hiding this comment.
Looks like it's used in some tools: https://github.com/search?q=log+repo%3Arust-lang%2Frust+path%3A*.toml&type=code&ref=advsearch
Looking at other crates.io dependencies, they don't have any special handling to appear in the compiler anymore so I think this is still safe to remove.
This was referenced Jun 25, 2024
Closed
Thomasdezeeuw
approved these changes
Jun 25, 2024
There was a problem hiding this comment.
Based on the precedent set in rust-lang/rust#122729 this LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a reworking of #520 using the same orderings. I think the main improvement was made in #610 so if we want to punt on this I think we reasonably can.