Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare for 0.4.21 release #617

Merged
merged 1 commit into from
Feb 28, 2024
Merged

Prepare for 0.4.21 release #617

merged 1 commit into from
Feb 28, 2024

Conversation

KodrAus
Copy link
Contributor

@KodrAus KodrAus commented Feb 27, 2024

cc @Thomasdezeeuw @JohnTitor This release stabilizes our structured logging API.

Closes #616

What's Changed

@nyurik
Copy link
Contributor

nyurik commented Feb 27, 2024

Should this be a minor change? I think we need to add two lines to the CI workflow as described here:

- name: Check semver
  uses: obi1kenobi/cargo-semver-checks-action@v2

@nyurik
Copy link
Contributor

nyurik commented Feb 27, 2024

I just added #618 - it might need to go in first to make sure we are not accidentally breaking semver contract

@nyurik
Copy link
Contributor

nyurik commented Feb 27, 2024

P.S. yes, it is clearly failing, possibly due to the current Cargo.toml having the same version as the published one. It seems patch version bump is not enough though.

My practice with that checker is that the version in the github main branch should be changed as soon as the breaking change is introduced. So either keep it as 0.5.0-pre.1 or as 0.5.0, but in either case it must not be 0.4.20 after the release and after the breaking changes are merged.

@Thomasdezeeuw
Copy link
Collaborator

Should this be a minor change?

What breaking changes do we have?

I think we need to add two lines to the CI workflow as described here:

Let's discuss this in the other pr.

@nyurik
Copy link
Contributor

nyurik commented Feb 27, 2024

@Thomasdezeeuw I see a bunch of the breaking changes in https://github.com/rust-lang/log/actions/runs/8072374937/job/22053982534?pr=618 -- do you think they are not correct?

@Thomasdezeeuw
Copy link
Collaborator

@Thomasdezeeuw I see a bunch of the breaking changes in https://github.com/rust-lang/log/actions/runs/8072374937/job/22053982534?pr=618 -- do you think they are not correct?

Looking at that output. The as_map and as_list related stuff was removed on purpose.
Two things renamed: Key::to_borrowed_str -> Key::as_str and Value::to_str -> Value::to_cow_str.

So it LGTM, all the changes were part of the unstable API.

@KodrAus
Copy link
Contributor Author

KodrAus commented Feb 28, 2024

Shipping this now 👍 I'll keep an eye on it over the next little while because releases with macro changes always come with risk.

@KodrAus KodrAus merged commit 3ccdc28 into master Feb 28, 2024
28 checks passed
@KodrAus
Copy link
Contributor Author

KodrAus commented Feb 28, 2024

@Thomasdezeeuw I've invited you to the organization I created where value-bag lives and will add you to the crate publishers too. Don't feel compelled to do anything if you're not interested (although you're very welcome to if you'd like!), but having permission to get builds and patches through there could be really useful someday.

@Thomasdezeeuw Thomasdezeeuw deleted the cargo/0.4.21 branch March 1, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release a build with kv support
4 participants