Remove use of unstable const_type_id feature (fixes CI failures on 1.47+) #418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `const_type_id` feature was planned to stabilize in Rust 1.47, but this was reverted in: rust-lang/rust#77083 This causes errors when building `log` with the `kv_unstable` feature on Rust 1.47 or later. This patch removes the use of this no-longer-stable feature in those Rust versions.
mbrubeck
changed the title
|
Ah! My bad 😄 I saw your message come through my notifications but thought it was a comment rather than a PR so I just pushed through #419 to fix this. I have an in-progress branch that refactors the guts of the Thanks for patching this up! 🙇 |
|
Re-opened and merged because this also fixes warnings in the build script. Thanks again! |
EFanZh
pushed a commit
to EFanZh/log
that referenced
this pull request
Jul 23, 2023
* Fix `cargo_toml`: Bump dep to v0.12.1 * Test `cargo-watch` in CI * Fix `*-test-Cargo.toml` used in integration tests Signed-off-by: Jiahao XU <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
const_type_idfeature was planned to stabilize in Rust 1.47, but this was reverted in rust-lang/rust#77083.build.rscurrently assumes the feature is stable in Rust 1.47 and later. This now causes errors when buildinglogwith thekv_unstablefeature on beta and nightly, which in turn is causing CI to fail on master.This patch simply removes the code that uses this feature, since it is not clear when it might be stabilized. Alternatively, the code could be kept around behind a second, nightly-only Cargo feature if it is still useful to someone. CC @KodrAus who added this code in #396.